only listen for Escape while it can close a menu - #896
Merged
MalpenZibo merged 1 commit intoAug 10, 2026
Conversation
Owner
|
Ok, for the fix. We should probably deprecate this function and move this feature to the IPC. It requires more settings on the compositor side (a new keybinding) but it should be a cleaner solution. |
MalpenZibo
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix 1/X
related to #895
The Escape-key subscription was always active, even though it can only do
something when
enable_esc_keyis set and a menu is open. An idlelisten_withsubscription is not free: iced copies every interaction eventinto a fixed-size channel per subscription and warns when it overflows.